Change api, Add support for s3 bucket resource and better cft loader #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
+ Coverage 78.22% 78.77% +0.55%
==========================================
Files 162 166 +4
Lines 4354 4406 +52
==========================================
+ Hits 3406 3471 +65
+ Misses 734 720 -14
- Partials 214 215 +1
|
| if allResourceConfigs[name] == nil { | ||
| t.Errorf("resource Type %s from test data %s not found", name, resourceDir) | ||
| } | ||
| for _, testResource := range resources { |
There was a problem hiding this comment.
Hey @sigmabaryon, I was wondering if deepEqual would have worked here? Because we are validating if the ID is present or not, but not validating other fields of the config resource.
patilpankaj212
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed iac loader
Added Load-file tests
Improved Load dir tests not right