Server mode: take file extension from uploaded file #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for scanning yml, json, etc. Slight security issue here taking file type from caller, but that issue already exists and I haven't fully evaluated the risk there...
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
+ Coverage 77.65% 77.68% +0.02%
==========================================
Files 102 102
Lines 2524 2527 +3
==========================================
+ Hits 1960 1963 +3
Misses 420 420
Partials 144 144
|
It is good an idea to add extensions based on iac-type. But, the changes in the current PR look good to me. We can add extensions based on iac-types if the current implementation fails for some scenario. |
kanchwala-yusuf
approved these changes
Mar 9, 2021
kanchwala-yusuf
pushed a commit
to kanchwala-yusuf/terrascan
that referenced
this pull request
Mar 9, 2021
This reverts commit 9546bcc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to take temp file extension from uploaded file so we can support more than .tf when in server mode.
Alternately - I was thinking of adding GetDefaultExtension() to each of the iac-providers and then naming the temp file based on the iac type passed. That might be a little more secure, but not by very much. Gimme thoughts...