Adding CFT scanning support for the resources: #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shreyas-phansalkar-189
commented
Feb 10, 2022
shreyas-phansalkar-189
commented
- aws_qldb_ledger
- aws_ecs_cluster
- aws_apigatewayv2_api
- aws_db_event_subscription
- aws_neptune_cluster_instance
- aws_globalaccelerator_accelerator
- aws_waf_size_constraint_set
- aws_athena_workgroup
- aws_qldb_ledger - aws_ecs_cluster - aws_apigatewayv2_api - aws_db_event_subscription - aws_neptune_cluster_instance - aws_globalaccelerator_accelerator - aws_waf_size_constraint_set - aws_athena_workgroup
shreyas-phansalkar-189
requested review from
cesar-rodriguez,
kanchwala-yusuf,
nasir-rabbani,
Rchanger and
patilpankaj212
gaurav-gogia
suggested changes
Feb 10, 2022
| // GetAPIGatewayV2ApiConfig returns config for aws_apigatewayv2_api resource | ||
| func GetAPIGatewayV2ApiConfig(a *apigatewayv2.Api) []AWSResourceConfig { | ||
|
|
||
| corsConfigData := make([]CorsConfigurationBlock, 1) |
There was a problem hiding this comment.
please add null check here
| } | ||
|
|
||
| // GetDBEventSubscriptionConfig returns config for aws_db_event_subscription resource | ||
| func GetDBEventSubscriptionConfig(db *rds.EventSubscription) []AWSResourceConfig { |
There was a problem hiding this comment.
prefer using single letter names like its being done with every other resource
| func GetEcsClusterConfig(e *ecs.Cluster) []AWSResourceConfig { | ||
|
|
||
| clusterSettingsData := make([]ClusterSettingsBlock, len(e.ClusterSettings)) | ||
| for i := 0; i < len(e.ClusterSettings); i++ { |
There was a problem hiding this comment.
we can use range here to make code cleaner
There was a problem hiding this comment.
Wouldnt we need i for indexing the clusterSettingsData array ?
There was a problem hiding this comment.
Try this:
for i := range e.ClusterSettings {
.....
}- api-gatewayv2-api.go - db-event-subscription.go Changes made: - added a nil check for CorsConfiguration - changed variable name in db-event-subscription.go
gaurav-gogia
approved these changes
Feb 11, 2022
gaurav-gogia
suggested changes
Feb 11, 2022
|
|
||
| func setExecCommandConfigBlock(e *ecs.Cluster) []ExecuteCommandConfiguration { | ||
|
|
||
| execCommandConfigData := make([]ExecuteCommandConfiguration, 1) |
There was a problem hiding this comment.
Please add null check
|
|
||
| func setLogConfigurationBlock(e *ecs.Cluster) []LogConfigurationBlock { | ||
|
|
||
| logConfigData := make([]LogConfigurationBlock, 1) |
There was a problem hiding this comment.
Please add null check
| func setSizeConstraintSet(w *waf.SizeConstraintSet) []SizeConstraintSetBlock { | ||
| sizeConstraintSet := make([]SizeConstraintSetBlock, len(w.SizeConstraints)) | ||
|
|
||
| for i := 0; i < len(w.SizeConstraints); i++ { |
There was a problem hiding this comment.
for i := range w.SizeConstraints {}this could be cleaner
|
Kudos, SonarCloud Quality Gate passed!
|
gaurav-gogia
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.