Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix input CFT templates based on goformation structs #1105

Merged
merged 2 commits into from
Jan 5, 2022
Merged

fix input CFT templates based on goformation structs #1105

merged 2 commits into from
Jan 5, 2022

Conversation

patilpankaj212
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 31, 2021 •
edited
Loading

Codecov Report

Merging #1105 (7224d06) into master (ddad143) will increase coverage by 0.10%.
The diff coverage is 81.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   78.56%   78.66%   +0.10%     
==========================================
  Files         238      239       +1     
  Lines        6503     6721     +218     
==========================================
+ Hits         5109     5287     +178     
- Misses       1079     1106      +27     
- Partials      315      328      +13
Impacted Files Coverage Δ
pkg/iac-providers/cft/v1/load-file.go 79.54% <71.42%> (-1.23%) ⬇️
pkg/iac-providers/cft/v1/sanitize-cft-template.go 82.21% <82.21%> (ø)

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kanchwala-yusuf
kanchwala-yusuf approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
nit: we need better comments for the fixWithType and examineStruct methods. Also, methods can be associated with the CFTV1{} struct

@kanchwala-yusuf kanchwala-yusuf merged commit 83afdb7 into tenable:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanchwala-yusuf kanchwala-yusuf kanchwala-yusuf approved these changes

@cesar-rodriguez cesar-rodriguez Awaiting requested review from cesar-rodriguez

@nasir-rabbani nasir-rabbani Awaiting requested review from nasir-rabbani

@Rchanger Rchanger Awaiting requested review from Rchanger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patilpankaj212 @kanchwala-yusuf