Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terrascan "latest" docker image broken for tfplan #718

Closed
xortim opened this issue Apr 30, 2021 · 3 comments · Fixed by #720
Closed

terrascan "latest" docker image broken for tfplan #718

xortim opened this issue Apr 30, 2021 · 3 comments · Fixed by #720

Comments

@xortim
Copy link
Contributor

xortim commented Apr 30, 2021

  • terrascan version: 1.5.1
  • Operating System: linux

Description

Running the same command fails between tagged 1.5.1 and 'latest'

What I Did

docker run --rm -v $(pwd):/workspace --workdir /workspace accurics/terrascan:1.5.1 scan -i tfplan -f /workspace/tfplan.out.json
...
Scan Summary -

	File/Folder         :	/workspace/tfplan.out.json
	IaC Type            :	tfplan
	Scanned At          :	2021-04-30 18:41:24.542798099 +0000 UTC
	Policies Validated  :	562
	Violated Policies   :	2
	Low                 :	1
	Medium              :	0
	High                :	1
docker run --rm -v $(pwd):/workspace --workdir /workspace accurics/terrascan:latest scan -i tfplan -f /workspace/tfplan.out.json
2021-04-30T18:42:43.959Z	error	cli/run.go:110	scan run failed{error 26 0  1 error occurred:
	* tfplan should always be a file, not a directory. Please specify path to tfplan file  with '-f' option
@amirbenv
Copy link
Contributor

Thanks for reporting! Looking into it. Currently using a release tag is safer than 'latest'. We may change that.

@jlk
Copy link
Contributor

jlk commented Apr 30, 2021

@xortim we've identified a fix for that, will have it merged in later today hopefully.

patilpankaj212 added a commit to patilpankaj212/terrascan that referenced this issue Apr 30, 2021
patilpankaj212 added a commit to patilpankaj212/terrascan that referenced this issue Apr 30, 2021
@patilpankaj212 patilpankaj212 linked a pull request Apr 30, 2021 that will close this issue
@jlk jlk closed this as completed in #720 Apr 30, 2021
@jlk
Copy link
Contributor

jlk commented Apr 30, 2021

@xortim - didn't mean to autoclose this with the PR merge. Let us know if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants