Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A scan should NOT crash if the notification doesn't work as expected #1044

Closed
devang-gaur opened this issue Oct 7, 2021 · 1 comment
Closed
Assignees
Labels

Comments

@devang-gaur
Copy link
Contributor

  • terrascan version:
  • Operating System:

Description

Describe what you were trying to get done.
Tell us what happened, what went wrong, and what you expected to happen.

I'm tryout the helm chart for admission controller capabilities. When I create an insecure pod, a scan is triggered, but due to the failure in the notification flow, the scan fails and terrascan allows that insecure pod to get created inside a cluster.

image

A failure in the notification feature flow should not block/sabotage the whole violation scan flow. The notification should be dispatched as a seperate goroutine.

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.
@nasir-rabbani
Copy link
Contributor

Fixed here : #1051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants