Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(1.0) New base AP models + Migrate to Concerto 1.0 #128

Merged
merged 6 commits into from
Apr 12, 2021
Merged

feature(1.0) New base AP models + Migrate to Concerto 1.0 #128

merged 6 commits into from
Apr 12, 2021

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Apr 1, 2021 •
edited
Loading

Signed-off-by: Jerome Simeon [email protected]

Changes

  • Proposal for new Accord Project base models in ./src/accordproject with simpler framework and compatibility with Concerto 1.0
  • Adjust existing models for Concerto 1.0
  • Leverages the new identified support in Concerto 1.0 and removes unneeded identifiers in the runtime classes (compared to the version in release-1.0)
  • Adds support for building with multiple Concerto versions
  • Switches to new concerto version syntax for models supported by 1.0.0

Flags

  • Will need multiple deployment since some of the new models are being referenced in the same PR

Related Issues

Flags

@jeromesimeon jeromesimeon changed the title [WIP] Some revisions to the base models for Concerto 1.0 feature(1.0) New based models for AP + Concerto 1.0 switch Apr 1, 2021
@jeromesimeon jeromesimeon changed the title feature(1.0) New based models for AP + Concerto 1.0 switch feature(1.0) New base models for AP + Concerto 1.0 switch Apr 3, 2021
@jeromesimeon jeromesimeon changed the title feature(1.0) New base models for AP + Concerto 1.0 switch feature(1.0) New base models for AP + Migrate to Concerto 1.0 Apr 9, 2021
@jeromesimeon jeromesimeon changed the title feature(1.0) New base models for AP + Migrate to Concerto 1.0 feature(1.0) Migrate to Concerto 1.0 + New base AP models Apr 9, 2021
@jeromesimeon jeromesimeon marked this pull request as draft April 9, 2021 13:22
@jeromesimeon jeromesimeon changed the title feature(1.0) Migrate to Concerto 1.0 + New base AP models feature(1.0) New base AP models + Migrate to Concerto 1.0 Apr 11, 2021
@jeromesimeon jeromesimeon mentioned this pull request Apr 11, 2021
Open
@jeromesimeon jeromesimeon marked this pull request as ready for review April 11, 2021 21:28
@jeromesimeon jeromesimeon merged commit ba4e2c3 into master Apr 12, 2021
@jeromesimeon jeromesimeon deleted the concerto-1.0 branch April 12, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolanglinais jolanglinais jolanglinais approved these changes

@dselman dselman Awaiting requested review from dselman

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromesimeon @jolanglinais