Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

durationAs calculation error minutes to hours #848

Closed
discochance opened this issue Feb 1, 2022 · 2 comments
Closed

durationAs calculation error minutes to hours #848

discochance opened this issue Feb 1, 2022 · 2 comments

Comments

@discochance
Copy link

Currently the durationAs implementation converts minutes into hours by multiplication of 60, which is wrong, it should be division by 60

ergo/compiler/stdlib/etime.ergo

Line 89 in 650da37

with minutes then du.amount * 60

@sanjeevbhusal
Copy link

Hey, can i work on this project?

@jeromesimeon jeromesimeon mentioned this issue Mar 17, 2022
Merged
@jeromesimeon
Copy link
Member

@discochance nice catch, thanks for the report. Fix in #865

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeromesimeon @discochance @sanjeevbhusal