Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macro "assert" passed 2 arguments, but takes just 1 #4

Open
hstig opened this issue May 12, 2022 · 1 comment
Open

macro "assert" passed 2 arguments, but takes just 1 #4

hstig opened this issue May 12, 2022 · 1 comment

Comments

@hstig
Copy link

hstig commented May 12, 2022

Simply used easylogging v9.89 and followed instruction. But I get following

qmllogging.h:184:70: error: macro "assert" passed 2 arguments, but takes just 1

  184 |     Q_INVOKABLE inline void assert(bool condition, const QString& msg) {
@hstig
Copy link
Author

hstig commented May 13, 2022

After undefined assert and defined ELPP_FEATURE_PERFORMANCE_TRACKING it results in

undefined reference to `vtable for el::qml::QmlLogging'

Resolved this by implementing virtual destructor in qmllogging.cpp

 #include "qmllogging.h"

 

 el::qml::TimeTracker::~TimeTracker(void) {

        m_timedBlocks.clear();

 }

and replaced in qmllogging.h

    virtual ~TimeTracker(void)
    {
        m_timedBlocks.clear();
    }

with

virtual ~TimeTracker(void); 

May there is a better way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant