Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conan option for default logfile inverse #812

Open
CrazyDaisyRecords opened this issue Jun 27, 2022 · 1 comment
Open

conan option for default logfile inverse #812

CrazyDaisyRecords opened this issue Jun 27, 2022 · 1 comment

Comments

@CrazyDaisyRecords
Copy link

Issue

The conan option "enable_default_logfile" behaves in a inverse way. The conanfile of the package version 9.97.0 handles the option as followed:

if self.options.enable_default_logfile:
            self.cpp_info.defines.append("ELPP_NO_DEFAULT_LOG_FILE")

Proposal

This option shall be handled inverse.

if not self.options.enable_default_logfile:
            self.cpp_info.defines.append("ELPP_NO_DEFAULT_LOG_FILE")
@prince-chrismc
Copy link

Not sure this is project is maintained but in CCI there's a PR for something similar to this conan-io/conan-center-index#14332

It would be amazing is the CCI build script could be brought back here to this project so everyone could benefit from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants