Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many pages show light theme, No deluminate option has an effect, extension UX changed unexpectedly #780

Open
quantumpotato opened this issue Aug 25, 2024 · 3 comments

Comments

@quantumpotato
Copy link

quantumpotato commented Aug 25, 2024

What version of Chrome are you using?

Brave 1.57.64

What version of Deluminate do you have installed?

1.0.1

What Operating System are you using?

OSX

What is the problem?

The extension appears to have been updated automatically? 1 week ago, clicking the extension showed a vertically oriented menu. The icon was different, too. Now, many webpages are showing a light theme which previously showed dark them. Clicking any of the deluminate options produces no effect. It used to be that I could click and change the theme easily by clicking the options and the page would update.

noeffect.mov

Can you link to a web page that has the problem?

https://news.ycombinator.com/
https://mail.proton.me

Which Deluminate modes have the problem?

All, nothing has an effect.

@quantumpotato
Copy link
Author

quantumpotato commented Aug 25, 2024

I removed the extension from Brave and now proton shows dark theme again, previously it showed light
Screen Shot 2024-08-25 at 12 36 26 PM
Screen Shot 2024-08-25 at 12 41 27 PM

@bwplotka
Copy link

bwplotka commented Sep 4, 2024

I see the same issue, after update Deluminate completely stopped working on many websites.

E.g. https://sysdig.com/blog/kubernetes-monitoring-prometheus/

This is how it looks on Deluminate enabled, on ANY option (changing options changes nothing):

image

Only when I disable Deluminate it gives me something readable:

image

Unfortunately I have to uninstall, block this for now and find another plugin for this, but I will keep an eye on when this is fixed.

I am on latest Mac and Chrome and don't see any relevant error in console.

@bwplotka
Copy link

bwplotka commented Sep 4, 2024

Ok, I reinstalled and it's better at least changing options has some effect, but swill reversing colors is pretty bad e.g. Dark Reader handles this better e.g. again same website:

Deluminate
image

Dark Reader
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants