Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen reddit videos being inverted on old.reddit.com and the old reddit UI #775

Open
miba54 opened this issue Aug 22, 2024 · 2 comments

Comments

@miba54
Copy link

miba54 commented Aug 22, 2024

What version of Chrome are you using?

Version 128.0.6613.85 (Official Build) (64-bit)

What version of Deluminate do you have installed?

1.0.0

What Operating System are you using?

Windows 10

What is the problem?

On old.reddit.com or when the old reddit UI is enabled through user settings, with the "Keep Images Normal" option selected, reddit videos get their colors inverted when fullscreened. This didn't use to happen before the big update, they used to stay untouched during fullscreen.

screenshot

Can you link to a web page that has the problem?

Just one example: https://old.reddit.com/r/Unexpected/comments/1eyh994/he_takes_his_job_seriously/ - OR- https://www.reddit.com/r/Unexpected/comments/1eyh994/he_takes_his_job_seriously/ (but with the old UI preference selected through reddit settings)

Which Deluminate modes have the problem?

Keep Images Normal

@miba54
Copy link
Author

miba54 commented Aug 24, 2024

Apparently this isn't limited to reddit. It happens on every video viewed on Chrome's built-in video player, and the old versions of reddit use that so that's why I thought it was reddit related at first.

For example, here's a direct link to a Twitter video but viewed with Chrome's native player: https://video.twimg.com/amplify_video/1824470067691786245/vid/avc1/720x720/dMuJHAHPZplViiOk.mp4

image

This is only one example. It happens on every site that utilizes Chrome's native player to play videos (like old reddit) or when viewing a direct link to a video.

@AditWongsaroj
Copy link

AditWongsaroj commented Aug 25, 2024

Same with a few other sites, seeing this on inspect:

html[hc*="delumine-noimg"]:not([hc*="dynamic"][looks-dark]) :-webkit-any(img, [style*="url"]:not([style*="transparent"]), [deluminate_imagetype], canvas, embed, object, video) {
filter: hue-rotate(180deg) invert(100%);
}

You can override it by adding an: element.style { filter: invert(0);}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@miba54 @AditWongsaroj and others