Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Domain users unassign optimization #2280

Closed
arvindh123 opened this issue Jun 7, 2024 · 1 comment · Fixed by #2325
Closed

Feature: Domain users unassign optimization #2280

arvindh123 opened this issue Jun 7, 2024 · 1 comment · Fixed by #2325
Assignees

Comments

@arvindh123
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Yes,
In Domain users unassign endpoint, we can provide multiple users for removal.
Lets take example user ids ["user_id_1", "user_id_2", "user_id_3"]

Domain users unassign has a for loop.
If it fails in second loop, then second and third user id are not removed and first user is remove.
The REST response will error, but in the response we could not say which all users are removed successfully and which all users not removed and which user got error

Describe the feature you are requesting, as well as the possible use case(s) for it.

Option 1:

Instead of having users as array, remove one user at a time.

Option 2:

Created a deatiled report in response error about which user ids are removed , which user id got error and which user ids are not removed

Option 3:

Just respond only the user id which got error .
To know the removed and unremoved users , list again the domain users .

Option 4:

Let it be as it is now. Don't say which userid got error .
To know the removed and unremoved users , list again the domain users .

Indicate the importance of this feature to you.

Must-have

Anything else?

No response

@github-project-automation github-project-automation bot moved this to Backlog in Magistrala Jun 7, 2024
@dborovcanin dborovcanin moved this from ⛏ Backlog to 🚧 In Progress in Magistrala Jun 12, 2024
@dborovcanin dborovcanin moved this from 🚧 In Progress to ⛏ Backlog in Magistrala Jun 12, 2024
@arvindh123
Copy link
Contributor Author

Waiting for PR #2197 to merge

@felixgateru felixgateru moved this from ⛏ Backlog to 🚧 In Progress in Magistrala Jul 2, 2024
@felixgateru felixgateru moved this from 🚧 In Progress to 🩺 Review and testing in Magistrala Jul 2, 2024
@github-project-automation github-project-automation bot moved this from 🩺 Review and testing to ✅ Done in Magistrala Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants