[sign_in_with_apple] Handle cancellation of chrome custom tab #88
Conversation
HenriBeck
changed the title
HenriBeck
changed the title
| if (requestCode == CUSTOM_TABS_REQUEST_CODE) { | ||
| val _lastAuthorizationRequestResult = lastAuthorizationRequestResult | ||
|
|
||
| if (_lastAuthorizationRequestResult != null) { |
There was a problem hiding this comment.
While this works from my testing on the simulator, I'm a bit worried about introducing a race condition here.
But maybe this activity result callback is only triggered after the deeplink is handled, e.g. triggering the main activity to hide the Custom Tab
There was a problem hiding this comment.
Hmm, true, we don't want this to be triggered on "automatic" closes.
Have you looked into the resultCode value? Is that any help?
Else I would hope there is some overall API docs on this that explains the order of method invocation.
I don't think SignInWithAppleCallback.onCreate leaves any room for races here, as we explicitly first send the data to Flutter and null the authorization result, and only then call triggerMainActivityToHideChromeCustomTab, which causes the tab to close.
I checked the resultCode and it was 0 (https://developer.android.com/reference/android/app/Activity#RESULT_CANCELED) both when manually closing as well as when it's triggered by this plugin.
…h-apple/handle-cancellation-of-chrome-custom-tab
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 62.34% 62.04% -0.31%
==========================================
Files 13 13
Lines 409 411 +2
==========================================
Hits 255 255
- Misses 154 156 +2
Continue to review full report at Codecov.
|
| val notificationIntent = _activity.getPackageManager().getLaunchIntentForPackage(_activity.getPackageName()); | ||
| lastAuthorizationRequestResult = result | ||
| triggerMainActivityToHideChromeCustomTab = { | ||
| val notificationIntent = _activity.packageManager.getLaunchIntentForPackage(_activity.packageName); | ||
| notificationIntent.setPackage(null) |
There was a problem hiding this comment.
| notificationIntent.setPackage(null) | |
| notificationIntent.package = null |
Is this also an option then?
| if (requestCode == CUSTOM_TABS_REQUEST_CODE) { | ||
| val _lastAuthorizationRequestResult = lastAuthorizationRequestResult | ||
|
|
||
| if (_lastAuthorizationRequestResult != null) { |
There was a problem hiding this comment.
Hmm, true, we don't want this to be triggered on "automatic" closes.
Have you looked into the resultCode value? Is that any help?
Else I would hope there is some overall API docs on this that explains the order of method invocation.
I don't think SignInWithAppleCallback.onCreate leaves any room for races here, as we explicitly first send the data to Flutter and null the authorization result, and only then call triggerMainActivityToHideChromeCustomTab, which causes the tab to close.
I checked the resultCode and it was 0 (https://developer.android.com/reference/android/app/Activity#RESULT_CANCELED) both when manually closing as well as when it's triggered by this plugin.
No description provided.