Add comment explaining the current implementation / execution order

aboutyou · Jun 2, 2020 · 282dadc · 282dadc
1 parent 821265e
commit 282dadc
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/...id/src/main/kotlin/com/aboutyou/dart_packages/sign_in_with_apple/SignInWithApplePlugin.kt b/...id/src/main/kotlin/com/aboutyou/dart_packages/sign_in_with_apple/SignInWithApplePlugin.kt
@@ -150,6 +150,8 @@ public class SignInWithAppleCallback: Activity {
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
 
+    // Note: The order is important here, as we first need to send the data to Flutter and then close the custom tab
+    // That way we can detect a manually closed tab in `SignInWithApplePlugin.onActivityResult` (by detecting that we're still waiting on data)
     val lastAuthorizationRequestResult = SignInWithApplePlugin.lastAuthorizationRequestResult
     if (lastAuthorizationRequestResult != null) {
       lastAuthorizationRequestResult.success(intent?.data?.toString())