Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license_url for GitHub Importer #656

Closed
TG1999 opened this issue Mar 28, 2022 · 9 comments · Fixed by #1392
Closed

Add license_url for GitHub Importer #656

TG1999 opened this issue Mar 28, 2022 · 9 comments · Fixed by #1392

Comments

@TG1999
Copy link
Contributor

TG1999 commented Mar 28, 2022

https://github.com/github/advisory-database/blob/main/LICENSE.md use this as license url

@iks1
Copy link

iks1 commented Jul 18, 2022

hi , i want to work on this issue. could you please tell how to proceed?

@ziadhany
Copy link
Collaborator

hi , i want to work on this issue. could you please tell how to proceed?

@iks1
Have a look at docs and just edit/add license_url, spdx_license_expression in importers/github.py
https://vulnerablecode.readthedocs.io/en/latest/tutorial_add_new_importer.html#specify-the-importer-license

@Akash-Kumar-Sen
Copy link

Hi @ziadhany I have gone through the documentation but it is not clear to me that where the 'license_url' actually resides and where to put it. If you can guide me a bit more that would be really helpful. Thank you.

@ziadhany
Copy link
Collaborator

@Akash-Kumar-Sen let's take a gitlab importer for example https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/importers/gitlab.py. We go to the repository ( data source ) https://gitlab.com/gitlab-org/advisories-community/-/tree/main and search for a LICENSE and add license_url , then we find the spdx_license_expression using https://spdx.org/licenses/

    spdx_license_expression = "MIT"
    license_url = "https://gitlab.com/gitlab-org/advisories-community/-/blob/main/LICENSE"

@Akash-Kumar-Sen
Copy link

Akash-Kumar-Sen commented Aug 15, 2022

@ziadhany
Copy link
Collaborator

@Akash-Kumar-Sen So you need to go to github importer https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/importers/github.py . add this in line 165.
license_url = "https://github.com/github/advisory-database/blob/main/LICENSE.md"

@Akash-Kumar-Sen
Copy link

@ziadhany thank you for your help, I am new to the world of open source, your help can be a milestone in my career.

@abhi-kr-2100
Copy link

This is still open despite pull request #845. If @Akash-Kumar-Sen is not working on this right now, I can open a new pull request.

@PankajJaisu
Copy link

Is the issue is still open and what is remaining to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants