Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use saneyaml instead of yaml #440

Closed
7 of 8 tasks
Hritik14 opened this issue Apr 15, 2021 · 4 comments · Fixed by #452
Closed
7 of 8 tasks

Use saneyaml instead of yaml #440

Hritik14 opened this issue Apr 15, 2021 · 4 comments · Fixed by #452

Comments

@Hritik14
Copy link
Collaborator

Hritik14 commented Apr 15, 2021

saneyaml is maintained by us (nexB) and it makes sense to update all the importers to use it instead of yaml.
Files currently requiring the fix.

  • - importers/suse_backports.py
  • - importers/elixir_security.py
  • - importers/istio.py
  • - importers/mozilla.py
  • - importers/alpine_linux.py
  • - tests/test_alpine.py
  • - tests/test_suse_backports.py
  • - helpers.py
@Hritik14 Hritik14 mentioned this issue Apr 15, 2021
6 tasks
@sbs2001
Copy link
Collaborator

sbs2001 commented Apr 16, 2021

@pombredanne is there any advantage of using saneyaml over standard yaml . AFAIK there is yaml.safe_load , we really don't do nything else with it here.

@sbs2001
Copy link
Collaborator

sbs2001 commented Apr 22, 2021

After discussion with @pombredanne I'm convinced that yaml is insane, and there is value in using saneyaml .

@Hritik14
Copy link
Collaborator Author

Hritik14 commented May 9, 2021

@sbs2001 imho, if you could post that conversation here, it would be very helpful for future contributors.

@Hritik14
Copy link
Collaborator Author

Rationale:

>>> yaml.load("phil: yes")
{'phil': True}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants