Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using required phrases in license rule for ranking matches instead of filtering #3945

Open
pombredanne opened this issue Oct 13, 2024 · 0 comments

Comments

@pombredanne
Copy link
Member

Required phrases in license rules are used to filter out matches that do not have these required phrases present.
There are cases where this is filtering too many matches and we would need to systematically re-run a second level "unknown" license detection afterwards.

We should consider using the presence of "required phrases" in a match for ranking instead.
A simple approach is rank matches with required phrases present higher or highest, but not discard the matches that are missing some or all of the required phrases, so that we still return lower scored matches in these edge cases where the match may have been one of a kind and should not have been filtered early even if imperfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant