From dd06801bd13a707d272f902eebdc4c5e298c2a73 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Fri, 22 Apr 2022 11:44:07 +0200 Subject: [PATCH] Integration test dependency cleanup (#1086) Integration test dependency cleanup SUMMARY remove dependencies on setup_remote_tmp_dir where it's not used (often just copy & paste from another test) remove setup_ec2 (no main.yml means it's not doing anything) remove prepare_tests (empty main.yml means it's not doing anything) ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration/targets ADDITIONAL INFORMATION By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did". Reviewed-by: Alina Buzachis Reviewed-by: Mark Woolley This commit was initially merged in https://github.com/ansible-collections/community.aws See: https://github.com/ansible-collections/community.aws/commit/dd12046a1e2d5f39692b1890ff07e06c56b3bf0e --- tests/integration/targets/rds_param_group/meta/main.yml | 4 +--- tests/integration/targets/rds_param_group/tasks/main.yml | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/integration/targets/rds_param_group/meta/main.yml b/tests/integration/targets/rds_param_group/meta/main.yml index 1f64f1169a9..32cf5dda7ed 100644 --- a/tests/integration/targets/rds_param_group/meta/main.yml +++ b/tests/integration/targets/rds_param_group/meta/main.yml @@ -1,3 +1 @@ -dependencies: - - prepare_tests - - setup_ec2 +dependencies: [] diff --git a/tests/integration/targets/rds_param_group/tasks/main.yml b/tests/integration/targets/rds_param_group/tasks/main.yml index 677260d5ee1..cf2d2f9ac40 100644 --- a/tests/integration/targets/rds_param_group/tasks/main.yml +++ b/tests/integration/targets/rds_param_group/tasks/main.yml @@ -11,7 +11,6 @@ # TODO - name: test 'validate_certs' parameter # ============================================================ -# - include: ../../setup_ec2/tasks/common.yml module_name=rds_param_group - name: rds_option_group tests collections: