From cb55efa7a4fda574b637f3b18c072cd2436e2a21 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sun, 21 Feb 2021 15:40:04 +0100 Subject: [PATCH] Yet more integration test aliases file cleanup (#431) * More aliases cleanup * Mark ec2_classic_lb tests unstable * Add more comments about why tests aren't enabled --- tests/integration/targets/aws_acm/aliases | 7 +++++-- tests/integration/targets/aws_config/aliases | 2 +- tests/integration/targets/aws_eks_cluster/aliases | 5 ++++- tests/integration/targets/aws_kms/aliases | 9 ++++++--- tests/integration/targets/aws_secret/aliases | 4 +++- .../targets/aws_step_functions_state_machine/aliases | 1 + tests/integration/targets/aws_waf_web_acl/aliases | 2 +- .../targets/cloudformation_exports_info/aliases | 5 +++-- tests/integration/targets/cloudwatchlogs/aliases | 1 + tests/integration/targets/connection/aliases | 1 + tests/integration/targets/ec2_asg/aliases | 4 ++-- tests/integration/targets/ec2_eip/aliases | 5 +++-- tests/integration/targets/ec2_instance/aliases | 1 + tests/integration/targets/ec2_transit_gateway/aliases | 1 + tests/integration/targets/ec2_vpc_endpoint/aliases | 1 + tests/integration/targets/ec2_vpc_igw/aliases | 1 + tests/integration/targets/ec2_vpc_nacl/aliases | 8 +++++--- tests/integration/targets/ec2_vpc_route_table/aliases | 8 +++++++- tests/integration/targets/ec2_vpc_vgw/aliases | 5 +++-- tests/integration/targets/ec2_vpc_vpn_info/aliases | 5 +++-- tests/integration/targets/ecs_ecr/aliases | 3 +++ tests/integration/targets/elb_classic_lb/aliases | 5 +++++ tests/integration/targets/elb_network_lb/aliases | 6 ++++-- tests/integration/targets/elb_target/aliases | 3 ++- tests/integration/targets/lambda/aliases | 1 + tests/integration/targets/route53/aliases | 3 ++- tests/integration/targets/s3_logging/aliases | 2 +- tests/integration/targets/s3_sync/aliases | 1 - 28 files changed, 71 insertions(+), 29 deletions(-) diff --git a/tests/integration/targets/aws_acm/aliases b/tests/integration/targets/aws_acm/aliases index c5a973f85c3..7f03376a735 100644 --- a/tests/integration/targets/aws_acm/aliases +++ b/tests/integration/targets/aws_acm/aliases @@ -1,4 +1,7 @@ +# https://github.com/ansible/ansible/issues/67788 +unstable + cloud/aws -aws_acm_info shippable/aws/group2 -unstable + +aws_acm_info diff --git a/tests/integration/targets/aws_config/aliases b/tests/integration/targets/aws_config/aliases index 932c8c7bb8d..3fb24852bed 100644 --- a/tests/integration/targets/aws_config/aliases +++ b/tests/integration/targets/aws_config/aliases @@ -1,6 +1,6 @@ # reason: missing-policy # We don't have CI or 'unsupported' policy for AWS config -disabled +unsupported cloud/aws shippable/aws/group2 diff --git a/tests/integration/targets/aws_eks_cluster/aliases b/tests/integration/targets/aws_eks_cluster/aliases index 3035c760534..452fa063069 100644 --- a/tests/integration/targets/aws_eks_cluster/aliases +++ b/tests/integration/targets/aws_eks_cluster/aliases @@ -1,4 +1,7 @@ -# reason: unknown +# reason: missing-policy +# We don't have CI or 'unsupported' policy for AWS config +# reason: slow +# Starting up an EKS cluster is a slow process, tests can take 40 minutes unsupported cloud/aws diff --git a/tests/integration/targets/aws_kms/aliases b/tests/integration/targets/aws_kms/aliases index f8c5aaa2d8e..d843dcfe965 100644 --- a/tests/integration/targets/aws_kms/aliases +++ b/tests/integration/targets/aws_kms/aliases @@ -1,5 +1,8 @@ -cloud/aws -aws_kms_info -shippable/aws/group2 # Various race conditions - likely needs waiters +# https://github.com/ansible-collections/community.aws/issues/433 unstable + +cloud/aws +shippable/aws/group2 + +aws_kms_info diff --git a/tests/integration/targets/aws_secret/aliases b/tests/integration/targets/aws_secret/aliases index e4280272565..da76731e85b 100644 --- a/tests/integration/targets/aws_secret/aliases +++ b/tests/integration/targets/aws_secret/aliases @@ -1,4 +1,6 @@ # reason: missing-policy -unsupported +# reason: broken +# The tests for configuring secret rotation seem to be missing a permission +disabled cloud/aws diff --git a/tests/integration/targets/aws_step_functions_state_machine/aliases b/tests/integration/targets/aws_step_functions_state_machine/aliases index 65b315eb47e..3ac1e6c4b4b 100644 --- a/tests/integration/targets/aws_step_functions_state_machine/aliases +++ b/tests/integration/targets/aws_step_functions_state_machine/aliases @@ -1,3 +1,4 @@ cloud/aws shippable/aws/group2 + aws_step_functions_state_machine_execution diff --git a/tests/integration/targets/aws_waf_web_acl/aliases b/tests/integration/targets/aws_waf_web_acl/aliases index 5d782911356..bbae3d77135 100644 --- a/tests/integration/targets/aws_waf_web_acl/aliases +++ b/tests/integration/targets/aws_waf_web_acl/aliases @@ -1,6 +1,6 @@ # reason: broken # ansible/ansible#38258 -unsupported +disabled cloud/aws diff --git a/tests/integration/targets/cloudformation_exports_info/aliases b/tests/integration/targets/cloudformation_exports_info/aliases index 777562fd9b9..c61e327ad48 100644 --- a/tests/integration/targets/cloudformation_exports_info/aliases +++ b/tests/integration/targets/cloudformation_exports_info/aliases @@ -1,4 +1,5 @@ -cloud/aws -shippable/aws/group3 # https://github.com/ansible-collections/community.aws/issues/157 unstable + +cloud/aws +shippable/aws/group3 diff --git a/tests/integration/targets/cloudwatchlogs/aliases b/tests/integration/targets/cloudwatchlogs/aliases index 500ca9a8ac1..513f7fc6344 100644 --- a/tests/integration/targets/cloudwatchlogs/aliases +++ b/tests/integration/targets/cloudwatchlogs/aliases @@ -1,4 +1,5 @@ cloud/aws shippable/aws/group1 + cloudwatchlogs_log_group cloudwatchlogs_log_group_metric_filter diff --git a/tests/integration/targets/connection/aliases b/tests/integration/targets/connection/aliases index 136c05e0d02..9edc56e9dcf 100644 --- a/tests/integration/targets/connection/aliases +++ b/tests/integration/targets/connection/aliases @@ -1 +1,2 @@ +# Used to test basic operation once a connection plugin has established a connection hidden diff --git a/tests/integration/targets/ec2_asg/aliases b/tests/integration/targets/ec2_asg/aliases index ae2bc1e9bd0..a1db4545242 100644 --- a/tests/integration/targets/ec2_asg/aliases +++ b/tests/integration/targets/ec2_asg/aliases @@ -1,6 +1,6 @@ # reason: slow -# reason: broken # Tests take around 30 minutes -unsupported +# reason: broken +disabled cloud/aws diff --git a/tests/integration/targets/ec2_eip/aliases b/tests/integration/targets/ec2_eip/aliases index 6ac56ac2486..204d0296c05 100644 --- a/tests/integration/targets/ec2_eip/aliases +++ b/tests/integration/targets/ec2_eip/aliases @@ -1,4 +1,5 @@ -cloud/aws -shippable/aws/group2 # https://github.com/ansible-collections/community.aws/issues/159 unstable + +cloud/aws +shippable/aws/group2 diff --git a/tests/integration/targets/ec2_instance/aliases b/tests/integration/targets/ec2_instance/aliases index 62cb1d2c5b5..c451297ee90 100644 --- a/tests/integration/targets/ec2_instance/aliases +++ b/tests/integration/targets/ec2_instance/aliases @@ -1,3 +1,4 @@ cloud/aws shippable/aws/group3 + ec2_instance_info diff --git a/tests/integration/targets/ec2_transit_gateway/aliases b/tests/integration/targets/ec2_transit_gateway/aliases index ce6c0771194..03098248a78 100644 --- a/tests/integration/targets/ec2_transit_gateway/aliases +++ b/tests/integration/targets/ec2_transit_gateway/aliases @@ -1,3 +1,4 @@ cloud/aws shippable/aws/group2 + ec2_transit_gateway_info diff --git a/tests/integration/targets/ec2_vpc_endpoint/aliases b/tests/integration/targets/ec2_vpc_endpoint/aliases index 0ed26a0a740..68d272f2799 100644 --- a/tests/integration/targets/ec2_vpc_endpoint/aliases +++ b/tests/integration/targets/ec2_vpc_endpoint/aliases @@ -1,3 +1,4 @@ cloud/aws shippable/aws/group2 + ec2_vpc_endpoint_info diff --git a/tests/integration/targets/ec2_vpc_igw/aliases b/tests/integration/targets/ec2_vpc_igw/aliases index 6b8a2ae5af7..7ab084e7a61 100644 --- a/tests/integration/targets/ec2_vpc_igw/aliases +++ b/tests/integration/targets/ec2_vpc_igw/aliases @@ -1,3 +1,4 @@ cloud/aws shippable/aws/group2 + ec2_vpc_igw_info diff --git a/tests/integration/targets/ec2_vpc_nacl/aliases b/tests/integration/targets/ec2_vpc_nacl/aliases index d82d1f9e4cd..a0b5045ec87 100644 --- a/tests/integration/targets/ec2_vpc_nacl/aliases +++ b/tests/integration/targets/ec2_vpc_nacl/aliases @@ -1,5 +1,7 @@ -ec2_vpc_nacl_info -cloud/aws -shippable/aws/group2 # https://github.com/ansible-collections/community.aws/issues/153 unstable + +cloud/aws +shippable/aws/group2 + +ec2_vpc_nacl_info diff --git a/tests/integration/targets/ec2_vpc_route_table/aliases b/tests/integration/targets/ec2_vpc_route_table/aliases index e4da78b0eb3..a7a2e37f611 100644 --- a/tests/integration/targets/ec2_vpc_route_table/aliases +++ b/tests/integration/targets/ec2_vpc_route_table/aliases @@ -1,4 +1,10 @@ +# reason: boto2 +# ec2_vpc_route_table_info is currently boto v2 based which means it can't handle API rate limiting +# https://github.com/ansible-collections/community.aws/issues/277 with AWSRetry +# would likely fix the issue. +unstable + cloud/aws shippable/aws/group2 -unstable + ec2_vpc_route_table_info diff --git a/tests/integration/targets/ec2_vpc_vgw/aliases b/tests/integration/targets/ec2_vpc_vgw/aliases index 0b8a330a44a..e65624834df 100644 --- a/tests/integration/targets/ec2_vpc_vgw/aliases +++ b/tests/integration/targets/ec2_vpc_vgw/aliases @@ -1,4 +1,5 @@ -cloud/aws -shippable/aws/group2 # https://github.com/ansible-collections/community.aws/issues/154 unstable + +cloud/aws +shippable/aws/group2 diff --git a/tests/integration/targets/ec2_vpc_vpn_info/aliases b/tests/integration/targets/ec2_vpc_vpn_info/aliases index e915bed8cba..3f72697111f 100644 --- a/tests/integration/targets/ec2_vpc_vpn_info/aliases +++ b/tests/integration/targets/ec2_vpc_vpn_info/aliases @@ -1,4 +1,5 @@ -cloud/aws -shippable/aws/group3 # https://github.com/ansible-collections/community.aws/issues/156 unstable + +cloud/aws +shippable/aws/group3 diff --git a/tests/integration/targets/ecs_ecr/aliases b/tests/integration/targets/ecs_ecr/aliases index 6e3860bee23..33058518543 100644 --- a/tests/integration/targets/ecs_ecr/aliases +++ b/tests/integration/targets/ecs_ecr/aliases @@ -1,2 +1,5 @@ +# reason: boto2 +unstable + cloud/aws shippable/aws/group2 diff --git a/tests/integration/targets/elb_classic_lb/aliases b/tests/integration/targets/elb_classic_lb/aliases index 6e3860bee23..d5fb10727a6 100644 --- a/tests/integration/targets/elb_classic_lb/aliases +++ b/tests/integration/targets/elb_classic_lb/aliases @@ -1,2 +1,7 @@ +# reason: boto2 +# elb_classic_lb is boto2 based which means that it handles rate limiting poorly +# https://github.com/ansible-collections/community.aws/issues/430 +unstable + cloud/aws shippable/aws/group2 diff --git a/tests/integration/targets/elb_network_lb/aliases b/tests/integration/targets/elb_network_lb/aliases index 2b0eed263eb..00f3632f6ee 100644 --- a/tests/integration/targets/elb_network_lb/aliases +++ b/tests/integration/targets/elb_network_lb/aliases @@ -1,4 +1,6 @@ -# reason: -unsupported +# reason: missing-policy +# reason: broken +# The SSL cert stored in the test has expired. Should be dynamically generated. +disabled cloud/aws diff --git a/tests/integration/targets/elb_target/aliases b/tests/integration/targets/elb_target/aliases index b99354591c1..932fe027725 100644 --- a/tests/integration/targets/elb_target/aliases +++ b/tests/integration/targets/elb_target/aliases @@ -1,3 +1,4 @@ cloud/aws -elb_target_group shippable/aws/group4 + +elb_target_group diff --git a/tests/integration/targets/lambda/aliases b/tests/integration/targets/lambda/aliases index c11244e5865..18f53946054 100644 --- a/tests/integration/targets/lambda/aliases +++ b/tests/integration/targets/lambda/aliases @@ -1,4 +1,5 @@ cloud/aws shippable/aws/group2 + execute_lambda lambda_info diff --git a/tests/integration/targets/route53/aliases b/tests/integration/targets/route53/aliases index f6cc7ad00c5..a70e7ee70b8 100644 --- a/tests/integration/targets/route53/aliases +++ b/tests/integration/targets/route53/aliases @@ -1,3 +1,4 @@ -route53_info cloud/aws shippable/aws/group2 + +route53_info diff --git a/tests/integration/targets/s3_logging/aliases b/tests/integration/targets/s3_logging/aliases index df4bfd632c6..edf3d5a90ad 100644 --- a/tests/integration/targets/s3_logging/aliases +++ b/tests/integration/targets/s3_logging/aliases @@ -1,5 +1,5 @@ # reason: unstable -# When running tests a failure rate of around 20% was observed +# https://github.com/ansible/ansible/issues/63520 unsupported cloud/aws diff --git a/tests/integration/targets/s3_sync/aliases b/tests/integration/targets/s3_sync/aliases index efe35f38150..a112c3d1bb2 100644 --- a/tests/integration/targets/s3_sync/aliases +++ b/tests/integration/targets/s3_sync/aliases @@ -1,3 +1,2 @@ cloud/aws shippable/aws/group1 -