From 970046e81fdba9ad8d8ae4423d7362fde1e2ed75 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Mon, 30 May 2022 11:50:50 +0200 Subject: [PATCH] elb_instance - remove ec2_elbs fact (#1173) elb_instance - remove ec2_elbs fact SUMMARY The ec2_elbs fact was deprecated when we migrated to boto3, remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See also: #773 Reviewed-by: Alina Buzachis --- elb_instance.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/elb_instance.py b/elb_instance.py index 51ec03d5702..b0dafecb9ee 100644 --- a/elb_instance.py +++ b/elb_instance.py @@ -55,8 +55,8 @@ default: 0 type: int notes: -- The ec2_elb fact currently set by this module has been deprecated and will no - longer be set after release 4.0.0 of the collection. +- The ec2_elbs fact previously set by this module was deprecated in release 2.1.0 and since release + 4.0.0 is no longer set. extends_documentation_fragment: - amazon.aws.aws - amazon.aws.ec2 @@ -388,13 +388,8 @@ def main(): elif module.params['state'] == 'absent': elb_man.deregister(wait, timeout) - # XXX We're not an _fact module we shouldn't be returning a fact and poluting - # the namespace - ansible_facts = {'ec2_elbs': [lb['LoadBalancerName'] for lb in elb_man.lbs]} - module.exit_json( changed=elb_man.changed, - ansible_facts=ansible_facts, updated_elbs=list(elb_man.updated_elbs), )