From f3446fd9e50714c66bbf9372100088ee40c266c2 Mon Sep 17 00:00:00 2001 From: Mandar Kulkarni Date: Mon, 23 Aug 2021 17:31:43 -0700 Subject: [PATCH 1/3] iam_role.py: update update_role_description to update_role --- plugins/modules/iam_role.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/iam_role.py b/plugins/modules/iam_role.py index e95ed0afddf..f5699edf8b5 100644 --- a/plugins/modules/iam_role.py +++ b/plugins/modules/iam_role.py @@ -327,7 +327,7 @@ def update_role_description(connection, module, params, role): return True try: - connection.update_role_description(RoleName=params['RoleName'], Description=params['Description'], aws_retry=True) + connection.update_role(RoleName=params['RoleName'], Description=params['Description'], aws_retry=True) except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e: module.fail_json_aws(e, msg="Unable to update description for role {0}".format(params['RoleName'])) return True From 9eea36dc99235b9fce88c28fc7692a1a777b666e Mon Sep 17 00:00:00 2001 From: Mandar Kulkarni Date: Mon, 23 Aug 2021 17:49:14 -0700 Subject: [PATCH 2/3] Added changelogs fragment. --- ...7-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml diff --git a/changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml b/changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml new file mode 100644 index 00000000000..24ab84446e9 --- /dev/null +++ b/changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml @@ -0,0 +1,2 @@ +bugfixes: +- iam_role - Modified iam_role to replace update_role_description with update_role (https://github.com/ansible-collections/community.aws/pull/697). From 2a5a4dd2a3a76d34e7b6ed60d180ebde9eea980a Mon Sep 17 00:00:00 2001 From: Mandar Kulkarni Date: Tue, 24 Aug 2021 15:15:23 -0700 Subject: [PATCH 3/3] Update changelogs fragment for better clarity --- ...7-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml b/changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml index 24ab84446e9..a31b43451d9 100644 --- a/changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml +++ b/changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml @@ -1,2 +1,2 @@ bugfixes: -- iam_role - Modified iam_role to replace update_role_description with update_role (https://github.com/ansible-collections/community.aws/pull/697). +- iam_role - Modified iam_role internal code to replace update_role_description with update_role (https://github.com/ansible-collections/community.aws/pull/697).