From 226d68a35e72d58ec23f5f7610c14008a4129994 Mon Sep 17 00:00:00 2001 From: Joseph Torcasso <87090265+jatorcasso@users.noreply.github.com> Date: Mon, 23 May 2022 21:29:45 -0400 Subject: [PATCH] rds_instance - add snapshot tests, update docs, refactor tests (#1081) rds_instance - add snapshot tests, update docs, refactor tests Depends-On: ansible-collections/amazon.aws#776 Depends-On: #1105 SUMMARY add snapshot tests to test restoring db from snapshot and fix bugs associated fix some typos in documentation and remove duplicate parameter (added as alias so no breaking change) remove unused IAM role in tests and add some missing cleanups ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION this module had both db_snapshot_identifier and snapshot_identifier as separate params, with the latter being required to restore from snapshot, resulting in some parameter missing errors. moving snapshot_identifier as an alias of db_snapshot_identifier fixes this issue. Reviewed-by: Alina Buzachis Reviewed-by: Joseph Torcasso Reviewed-by: Mark Chappell Reviewed-by: Sloane Hertel This commit was initially merged in https://github.com/ansible-collections/community.aws See: https://github.com/ansible-collections/community.aws/commit/5d5bca9476476baa48765e8ede8ef98148f13734 --- plugins/modules/rds_cluster.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/rds_cluster.py b/plugins/modules/rds_cluster.py index 16f2ed5a97a..1d2ed3fdd9b 100644 --- a/plugins/modules/rds_cluster.py +++ b/plugins/modules/rds_cluster.py @@ -758,7 +758,7 @@ def get_rds_method_attribute_name(cluster): method_name = 'modify_db_cluster' method_options_name = 'get_modify_options' elif creation_source == 'snapshot': - method_name = 'restore_db_cluster_from_db_snapshot' + method_name = 'restore_db_cluster_from_snapshot' method_options_name = 'get_restore_snapshot_options' elif creation_source == 's3': method_name = 'restore_db_cluster_from_s3'