Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with playwright 1.31 and lighthouse 9 #47

Closed
grybykm opened this issue Feb 22, 2023 · 2 comments
Closed

Doesn't work with playwright 1.31 and lighthouse 9 #47

grybykm opened this issue Feb 22, 2023 · 2 comments

Comments

@grybykm
Copy link

grybykm commented Feb 22, 2023

I'm no longer able to run lighthouse because of: Cannot create new tab, and no tabs already open. since I've upgraded the playwright to v1.31. I'm still using lighthouse v9.

Maybe it is somehow related to chromium update or GoogleChrome/lighthouse#14736.
I haven't tried switching to lighthouse v10 because after upgrading the lighthouse I'm getting:

    import log from 'lighthouse-logger';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

Did anyone manage to upgrade to the latest playwright version and keep their lighthouse tests running?

@yardenhochman
Copy link

I have the same issue

@grybykm
Copy link
Author

grybykm commented Jun 20, 2023

There are two ways to deal with this one:

  • build a wrapper package around lighthouse and playwright-lighthouse to convert these packages from type module to normal ones. I have actually built one but decided to choose another
  • upgrade the project to use type module

First, I built and published to npm a wrapper as a workaround but decided not to proceed further with it.

Finally, I've chosen the second option even though I had to change ALL the files in my project as far as it is more feature oriented.

@grybykm grybykm closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants