Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Support multi-job workflows #5

Open
sdgluck opened this issue Feb 17, 2021 · 1 comment
Open

Support multi-job workflows #5

sdgluck opened this issue Feb 17, 2021 · 1 comment

Comments

@sdgluck
Copy link

sdgluck commented Feb 17, 2021

Hey great action, and I'd love to use it in our org.

The only issue is that our deploy workflow has over ten separate jobs.

AFAICT, at the moment this action only supports locking within the context of a single job?

What changes would be necessary to be able to support locking and unlocking in different jobs? Say, the first and last job in a workflow would do the locking and unlocking respectively. I envisage something like an input to the action which specifies whether it should perform a lock or unlock operation. When specifying the unlock, the user job would have an if: always() condition.

Look forward to hearing your thoughts.

@abatilo
Copy link
Owner

abatilo commented Mar 3, 2021

Hey @sdgluck, so sorry on the delay on this. I've been meaning to respond for weeks.

Anyways, the changes would be minimal overall, I think? I don't know if there's a way to conditionally run the post-entrypoint but if there is, we could have some kind of mode for which way to run.

The reason I wanted to use the post-entrypoint was to basically guarantee an unlock even if you forgot the if: always().

Do you actually need to lock everything over your 10 separate jobs? Can you lock each one individually?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants