Skip to content

Commit

Permalink
roachtest: set config.Quiet to true
Browse files Browse the repository at this point in the history
After refactoring in [1], the default of config.Quiet
was set to false since the roachprod CLI option is intended to
set it to true. This resulted in an unwanted side-effect, namely
roachtests running with the new default. Consequently, test_runner's
log ended up with a bunch of (terminal) escape codes due to (status)
spinner.

This change ensures roachtest explicitly sets config.Quiet to true.

[1] cockroachdb#99133

Epic: none

Release note: None
  • Loading branch information
srosenberg committed Apr 4, 2023
1 parent 44f3f31 commit 6c4d605
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/cmd/roachtest/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ runner itself.
fmt.Fprintf(os.Stderr, "unable to lookup current user: %s\n", err)
os.Exit(1)
}
// Disable spinners and other fancy status messages since all IO is non-interactive.
config.Quiet = true

if err := roachprod.InitDirs(); err != nil {
fmt.Fprintf(os.Stderr, "%s\n", err)
Expand Down

0 comments on commit 6c4d605

Please sign in to comment.