Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Search widget #23

Open
abalakh opened this issue Feb 19, 2018 · 0 comments
Open

Refactor Search widget #23

abalakh opened this issue Feb 19, 2018 · 0 comments

Comments

@abalakh
Copy link
Owner

abalakh commented Feb 19, 2018

Current implementation doesn't respect layers isolation - read() returns not value of searchbar, but value of results table, which is outside of widget and should be handled on view level. Such implementation will also cause issues when automating some uncommon entities where multiple fields from results table should be taken into consideration.
Ideally widget's fill and read should only work with searchbar, and view should contain separate search() method which will return results from table.
We can also think of some SearchableMixin for views not to have to implement search for every view, since most of views will have very similar implementation and only locator will differ in most cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant