Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression option with pako cause error #1091

Open
KeyboardRage opened this issue Nov 29, 2020 · 1 comment
Open

Compression option with pako cause error #1091

KeyboardRage opened this issue Nov 29, 2020 · 1 comment

Comments

@KeyboardRage
Copy link

In the bot options if you set compression: true and are using the pako library, you will get an undefined error.

TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined

zlib-sync seems to work fine.

Found on Eris 0.14.0, NodeJs v14.15.1 on Windows 10.

@abalabahaha
Copy link
Owner

Interesting, looks like pako@2 dropped Z_SYNC_FLUSH in nodeca/pako#196. pako@1 should work for now, try that version if you're still interested. The author claims this parameter is not necessary during inflation, so this needs more investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants