Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Natspec type error in _getProxyImplementation() function inside the contract PoolAddressesProvider #930

Open
MatinR1 opened this issue Dec 15, 2023 · 0 comments · May be fixed by #932
Open

Natspec type error in _getProxyImplementation() function inside the contract PoolAddressesProvider #930

MatinR1 opened this issue Dec 15, 2023 · 0 comments · May be fixed by #932

Comments

@MatinR1
Copy link

MatinR1 commented Dec 15, 2023

The natspec of the function _getProxyImplementation() inside the contract PoolAddressesProvider has an extra [the](https://github.com/aave/aave-v3-core/blob/master/contracts/protocol/configuration/PoolAddressesProvider.sol#L194) between Returnsandimplementation`:

  • @notice Returns the the implementation contract of the proxy contract by its identifier.

Consider removing one of the thes.
@0xScratch 0xScratch linked a pull request Jan 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PoolAddressesProvider.sol: natspec changes 0xScratch/aave-v3-core
1 participant
@MatinR1