fix: update hardhat dependencies and fix test-suite error codes #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartojal
requested review from
The-3D,
miguelmtzinf,
stevenvaleri,
foodaka,
Zer0dot,
donosonaumczuk and
BenSparksCode
as code owners
kartojal
force-pushed
the
fix/test-suite-and-deps
branch
from
03ceb26
to
2dd33bd
Compare
kartojal
force-pushed
the
fix/test-suite-and-deps
branch
from
4be73e4
to
05f7cb0
Compare
kartojal
force-pushed
the
fix/test-suite-and-deps
branch
from
05f7cb0
to
7b0c975
Compare
miguelmtzinf
approved these changes
Nov 25, 2022
This was referenced Aug 16, 2024
This was referenced Aug 24, 2024
This was referenced Sep 1, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
After performing maintenance of NPM dependencies and upgrading from waffle and old chai matchers to
hardhat-toolboxtooling suite, noticed at the test suite that some matchers where not failing correctly, resulting in fake positives.