Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimeConverter #231

Closed
justinyoo opened this issue Jan 8, 2017 · 2 comments
Closed

DateTimeConverter #231

justinyoo opened this issue Jan 8, 2017 · 2 comments

Comments

@justinyoo
Copy link
Contributor

justinyoo commented Jan 8, 2017 •
edited
Loading

Hi,

I know there's only one converter out-of-the-box, ie. GuidConverter.

YamlDotNet itself can convert string to DateTime automatically and vice-versa. However, if the date/time format is not that expected, it fails conversion. Would it be part of your roadmap to include those frequently used converters within the library at some stage? I can send a PR for DateTimeConverter, if you like.

It's probably related to #196 (DateTimeOffset) issue by the way.

Cheers,
@justinyoo justinyoo changed the title DateTimeConverter or NullableDateTimeConverter DateTimeConverter Jan 8, 2017
@aaubry
Copy link
Owner

aaubry commented Jan 9, 2017

Hi,

Sure, it would be good to have a DateTimeConverter so that we can configure the conversion behavior. Please send a PR that adds it. Thanks

@justinyoo
Copy link
Contributor Author

@aaubry Sure. Will send PR soon. Thanks for accepting my suggestion.

@justinyoo justinyoo mentioned this issue Jan 11, 2017
Merged
@aaubry aaubry closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaubry @justinyoo