Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency issues #50

Merged
merged 9 commits into from
Feb 26, 2024
Merged

Fix dependency issues #50

merged 9 commits into from
Feb 26, 2024

Conversation

turnmanh
Copy link
Collaborator

@turnmanh turnmanh commented Feb 5, 2024 •
edited
Loading

Fixing

  • notebook==6.5.6 to pre version 7.*
  • fixing rise==5.7.1
  • fixing overall package dep. in order to be able to install it
  • Lex. ordering of imports in notebooks
  • Re-compilation of docs.

closes #46, closes #49

@turnmanh turnmanh added bug Something isn't working enhancement New feature or request labels Feb 5, 2024
@turnmanh turnmanh linked an issue Feb 5, 2024 that may be closed by this pull request
Fix notebook version #46
Closed
@turnmanh turnmanh changed the title Draft: Fix dependency issues Fix dependency issues Feb 6, 2024
@turnmanh turnmanh marked this pull request as draft February 6, 2024 09:54
@turnmanh turnmanh marked this pull request as ready for review February 6, 2024 11:58
@turnmanh
Copy link
Collaborator Author

@fariedabuzaid can you please review.

fariedabuzaid
fariedabuzaid approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@fariedabuzaid fariedabuzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@fariedabuzaid fariedabuzaid merged commit 9b98662 into master Feb 26, 2024
1 check passed
@fariedabuzaid fariedabuzaid deleted the 46-fix-notebook-version branch February 26, 2024 15:28
@turnmanh turnmanh mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fariedabuzaid fariedabuzaid fariedabuzaid approved these changes

Assignees

@fariedabuzaid fariedabuzaid

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install -e "." does not work Fix notebook version
2 participants
@turnmanh @fariedabuzaid