From 154a905f2d509410b3261851348627118c0f6c28 Mon Sep 17 00:00:00 2001 From: Aaditya Sondhi <20070511+aadityasondhi@users.noreply.github.com> Date: Tue, 17 Dec 2024 11:13:53 -0500 Subject: [PATCH] admission: turn on snapshot ingest bandwidth control by default With https://github.com/cockroachdb/cockroach/pull/133310 merged, and promising results from internal experimentation, we can turn this setting on by default. Informs: #121779. Release note (ops change): `kvadmission.store.snapshot_ingest_bandwidth_control.enabled` is now 'true' by default. This will enable disk bandwidth based Admission Control for range snapshot ingests. It requires the provisioned bandwidth to be set using `kvadmission.store.provisioned_bandwidth`. --- pkg/util/admission/snapshot_queue.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/util/admission/snapshot_queue.go b/pkg/util/admission/snapshot_queue.go index efec2abab3a1..d491d9e82b71 100644 --- a/pkg/util/admission/snapshot_queue.go +++ b/pkg/util/admission/snapshot_queue.go @@ -49,8 +49,7 @@ var snapshotWorkItemPool = sync.Pool{ var DiskBandwidthForSnapshotIngest = settings.RegisterBoolSetting( settings.SystemOnly, "kvadmission.store.snapshot_ingest_bandwidth_control.enabled", "if set to true, snapshot ingests will be subject to disk write control in AC", - // TODO(aaditya): Enable by default once enough experimentation is done. - metamorphic.ConstantWithTestBool("kvadmission.store.snapshot_ingest_bandwidth_control.enabled", false), + metamorphic.ConstantWithTestBool("kvadmission.store.snapshot_ingest_bandwidth_control.enabled", true), settings.WithPublic, )