Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels for tags and name override each other depending on ordering #88

Open
febbraro opened this issue Dec 20, 2016 · 5 comments
Open

Comments

@febbraro
Copy link
Contributor

febbraro commented Dec 20, 2016

It appears that com.dnsdock.tags and com.dnsdock.name cannot be used together as they populate the same space in the domain name. It is further complicated by the fact that which ever one is defined last wins. Is there a reason we don't set it up such that tags and name populate different parts of the domain name? Also, the docs are unclear about what to use when, and appear contradictory.

If you are open to changing a bit of how the names are built I can work on a PR and doc updates.

When looking at all the options this seems to make the most sense to me. I'm wondering what you think....
<tag>.<name>.<region>.<image>.<environment>.<domain>

@febbraro
Copy link
Contributor Author

Also, it looks like you can specify many tags, comma separated, but it will only ever use the first one. Was the eventual intention if there were multiple tags that it would use the tags and create an entry per tag?

@aacebedo
Copy link
Owner

Hi !
You're completely right about this issue !
I am OK with your proposal of having multiple alias with the scheme you propose.
Feel free to do a PR. If you can't tell me I'll do the modifications

@febbraro
Copy link
Contributor Author

febbraro commented Jan 9, 2017

Sorry for the delay here. I'm working on something and hope to put a PR together by the end of the week. Working through learning the right way to develop dnsdock w/ rocker, etc.

@febbraro
Copy link
Contributor Author

PR #99 was submitted to address this issue.

@febbraro
Copy link
Contributor Author

Any feedback on this PR/Issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants