New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rias uses wrong formula for height #550

Closed

rulatir opened this issue Oct 28, 2018 · 0 comments

rulatir commented Oct 28, 2018

lazysizes/plugins/rias/ls.rias.js

Line 164 in d7e043d

.replace(regHeight, options.ratio ? Math.round(width * options.ratio) : ''),

In pseudocode, if ratio == width/height then height = width/ratio, not width * ratio. How come nobody caught this before?

The text was updated successfully, but these errors were encountered:

aFarkas closed this as completed in

df41b88

sacr3dc0w mentioned this issue

lazysizes 5.0.0 bigcommerce/cornerstone#1499

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment