Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new symbolic-friendly vm cheatcodes #365

Open
karmacoma-eth opened this issue Sep 17, 2024 · 2 comments
Open

feat: add support for new symbolic-friendly vm cheatcodes #365

karmacoma-eth opened this issue Sep 17, 2024 · 2 comments
Labels
devex enhancement New feature or request good first issue Good for newcomers

Comments

@karmacoma-eth
Copy link
Collaborator

foundry-rs/foundry#8807
foundry-rs/foundry#8882

we may want to replace our custom svm.enableSymbolicStorage(address) with the equivalent (but foundy and kontrol-compatible) vm.setArbitraryStorage(address target)

@karmacoma-eth karmacoma-eth added bug Something isn't working enhancement New feature or request good first issue Good for newcomers devex and removed bug Something isn't working labels Sep 17, 2024
@pillip
Copy link
Contributor

pillip commented Oct 19, 2024

@karmacoma-eth @daejunpark
Can I take on this issue and work on it?

@daejunpark
Copy link
Collaborator

sure, that sounds great! thank you, @pillip!

for backward compatibility, i suggest introducing the new cheatcodes as aliases to the existing ones:

  • setArbitraryStorage => enableSymbolicStorage
  • random* => create*

please note that copyStorage and mockFunction are not currently supported, so they are outside the scope of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants