-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to package:web
#122
Comments
The migration will not be a little task and I'd prefer that package:web 0.3.0 was not in preview and not with a This package is highly experimental warning. |
We don't have docs...yet. We're holding off because we're waiting on extension types to start encouraging migrations. Look at this diff for inspiration, though: flutter/packages@main...pkg_web_wip |
You'll HAVE to do a branch – or depend on a dev SDK to do the migration. Another option is to wait for the next Dart release! |
I made a branch with some small tweaks to get the script running, but the generated code has a lot of errors: master...johnpryan:dart-google-maps:pkg_web @a14n have you had time to look at this lately? |
Not really for now but I just recover my setup and I will try to take a look soon (hopefully in the coming days/weeks) |
I just pushed a branch package-web containing the lib/ folder migrated to package:web. The example folder migration is in progress but you can already try the lib now. The generator tool is not yet updated to use package:web instead of dart:html. In the future I also plan to use static js interop but it requires more work so it is likely that this will not happen soon. Side note about this migration : it was not obvious how to pass a JSFunction required by some functions like |
@a14n You can make a
where the arg is a JS type accepted by the compiler (so all the primitives: String, bool, int, double, null, and also JS types JSArray, JSObject, JSAny) If you have a JSFunction and you need to call it in Dart, use the |
I just push a 7.0.0-beta.1 version on pub you can use. Let me know when you test it and validate. Then I'll publish a 7.0.0. |
I updated the mentioned branch to run with |
@a14n All the integration tests for google_maps_flutter_web pass locally for me. I think that is a good sign to publish |
|
This issue is a proposal to migrate from
dart:html
topackage:web
.This would unblock migrating
google_maps_flutter_web
in flutter/packages#5254The text was updated successfully, but these errors were encountered: