Error for unrecognized lift manifest fields.
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point to the manifest format docs and make these easier to access via new support for `science doc open <page>` to enable using `science doc open manifest` to directly oprn the manifest docs.
jsirois
commented
Sep 23, 2023
| @@ -2,7 +2,7 @@ | |||
| name = "igs" | |||
| description = "Test interpreter group selection." | |||
|
|
|||
| [lift.scie-jump] | |||
| [lift.scie_jump] | |||
There was a problem hiding this comment.
N.B.: Before adding any tests, the existing tests failed here on the scie-jump mis-spell. This same silent (before) error was what bit @huonw in scie-pants recently.
…and pwsh.exe, just use `\n` for display always.
kaos
approved these changes
Sep 24, 2023
jsirois
added a commit
that referenced
this pull request
Sep 24, 2023
The logic introduced in #47 was overly complex. There is never an active `DocConfig` outside a `science doc ...` command invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46