Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Add children doesn't support uppercase modes #287

Closed
Tiagoperes opened this issue Oct 19, 2020 · 0 comments · Fixed by #290
Closed

Add children doesn't support uppercase modes #287

Tiagoperes opened this issue Oct 19, 2020 · 0 comments · Fixed by #290
Assignees
@hectorcustodiozup
Labels
bug Something isn't working next version Should be released in the next medium or major version (not just a patch)

Comments

@Tiagoperes
Copy link
Contributor

Beagle Web version:

Steps To Reproduce

  1. Use addChildren with mode "PREPEND"

The current behavior

It will do nothing

The expected behavior

It should prepend the content

Solution

Before comparing the modes, convert to lowercase. These values should be case insensitive. the backend always return the modes in all caps.
@Tiagoperes Tiagoperes added bug Something isn't working next version Should be released in the next medium or major version (not just a patch) labels Oct 19, 2020
@hectorcustodiozup hectorcustodiozup self-assigned this Oct 22, 2020
@hectorcustodiozup hectorcustodiozup mentioned this issue Oct 22, 2020
Merged
@snykbotzup snykbotzup mentioned this issue Mar 17, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hectorcustodiozup hectorcustodiozup

Labels
bug Something isn't working next version Should be released in the next medium or major version (not just a patch)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds toLowerCase before mode comparison ZupIT/beagle-web-core
2 participants
@Tiagoperes @hectorcustodiozup