Fixes for GD32F205 USB serial #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously USB serial number was disabled to save RAM, but the length was left as 12. This confused Windows and caused USB enumeration to fail. Changed serial number to fake "1234". This avoids Windows from guessing a new COM port number every time the device is changed between ports.
usb_log_poll() was bringing in unnecessary code, causing bootloader to be larger than needed and exceed 32 kB.
Return proper error on unknown requests. Don't hang on received data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression with GD32F205 USB enumeration on Windows.
Also includes a few other USB related fixes.