Merge the RP2350 and the RP2040 base MCU platform libraries into a common library #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootloader works for Pico 2s. Putting a `zuluscsi.bin` file will now update the firmware. Also increased the SRAM size from the RP2040 to the RP2350 max size.
With the RP2350 at 150MHz, one clock cycle is 6.67 ns (150MHz) => delay 8.25 clocks or 9 clocks .define REQ_DLY 9. Thanks, @morio
Moved the RP2040 and RP2350 to the same customized arduino pico framework. That is compatible with both USB mass storage and the DaynaPORT Pico W SPI pio Wifi interface. Other changes include a base PlatformIO target that all RP builds inherit from. This gets rid of a lot of repeated settings. An unrelated change was the added the ability to set the timeout for USB enumeration as sometimes RP devices take longer than second to enumerate when on a USB hub. And adding both `EnableUSBMassStorage` and the new `USBMassStorageWaitPeriod` to the example `zuluscsi.ini` file.
Since the arduino pico library and the pico-sdk automatically build for either the RP2040 and RP23XX MCUs, both libraries have been merged into `lib/ZuluSCSI_platform_RP2MCU` with `#if` type C macros for some of the files and code snippets that are tied to the MCU. For example RP's PIO assembly files, timing delays and clock dividers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the RP2350 and RP2040 base MCU library code into a shared library ZuluSCSI_platform_RP2MCU.
It also updates the arduino-pico framework to the latest version with customizations for DaynaPORT and mass storage device support.