CD-ROM: Support PREGAP in .cue files #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bytes CD images in bin/cue format can have sector size that is not divisible by 512. That's why the real file size must be reported and not rounded to sector boundary. Only use sector-aligned size for RAW mapping.
When CD-ROM image has PREGAP specified, that is included in TOC timestamps but not actually present in the image file. Adjust data_start and track_start accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
PREGAPspecifier in .cue files was ignored.This pull request adds support for it.
Also includes fix for incorrect image length if sector size is not divisible by 512. Previously for CD files in 2352 sector format the reported data length could be one sector too short.
Tests done:
readcd -fulltocandcdrdao read-cdnow produces identical results as with real Lite-On CD drive and CD-R burned from the same files.beos-5.0.3-professional-gobe.cuewithcdrdao read-cdgives identical .bin and .cue as the input data (this was working already previously, tested against to check for any regressions).Fixes #422.