Fix select phase of ZuluSCSI v1.2 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the GD32F205 based board have their SCSI select input signal moved to a different GPIO. The interrupt for the select signal didn't reflect this possibility. Adding logic to differentiate boards with or without this signal pin difference fixes the issue where some systems were failing the select phase.
Added GPIO placeholder defines used for V1.1plus for the SCSI in select signal which were missing to the V1.0 GPIO header file. This fixed the compiler errors for the v1.0 base boards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the GD32F205 based boards have their SCSI select input signal moved to a different GPIO. The interrupt for the select signal didn't reflect this possibility. Adding logic to differentiate boards with or without this signal pin difference fixes the issue where some systems were failing the select phase.