From abf339588ade9298ff9b7448eea946b2e88127e9 Mon Sep 17 00:00:00 2001 From: Morio Date: Tue, 19 Sep 2023 17:28:00 -0700 Subject: [PATCH] Update messaging for both the rev 2023b and 2023c Both rev 2023b and 2023c boards have issues with reading two of the dip switch setting. Updated the messaging around this to include both revisions. --- lib/ZuluSCSI_platform_RP2040/ZuluSCSI_platform.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ZuluSCSI_platform_RP2040/ZuluSCSI_platform.cpp b/lib/ZuluSCSI_platform_RP2040/ZuluSCSI_platform.cpp index 2b220553..d853ff31 100644 --- a/lib/ZuluSCSI_platform_RP2040/ZuluSCSI_platform.cpp +++ b/lib/ZuluSCSI_platform_RP2040/ZuluSCSI_platform.cpp @@ -112,9 +112,9 @@ static pin_setup_state_t read_setup_ack_pin() * The 74LVT245 hold current is keeping the GPIO_ACK state too strongly. * Detect this condition by toggling the pin up and down and seeing if it sticks. * - * Revision 2023b of the Pico hardware has issues reading TERM and DEBUG DIP switch + * Revision 2023b and 2023c of the Pico boards have issues reading TERM and DEBUG DIP switch * settings. GPIO_ACK is externally pulled down to ground for later revisions. - * If the state is detected as undetermined then the board is the 2023b revision. + * If the state is detected as undetermined then the board is the 2023b or 2023c revision. */ // Strong output high, then pulldown @@ -171,7 +171,7 @@ void platform_init() bool dbglog = false; bool termination = false; # ifdef ZULUSCSI_PICO - // Initiator dip setting works on both rev 2023b and newer rev Pico boards + // Initiator dip setting works on all rev 2023b, 2023c, and newer rev Pico boards g_scsi_initiator = !gpio_get(DIP_INITIATOR); working_dip = SETUP_UNDETERMINED != read_setup_ack_pin(); @@ -221,7 +221,7 @@ void platform_init() { logmsg("SCSI termination is determined by the DIP switch labeled \"TERM\""); logmsg("Debug logging can only be enabled via INI file \"DEBUG=1\" under [SCSI] in zuluscsi.ini"); - logmsg("-- DEBUG DIP switch setting is ignored on ZuluSCSI Pico FS Rev. 2023b boards"); + logmsg("-- DEBUG DIP switch setting is ignored on ZuluSCSI Pico FS Rev. 2023b and 2023c boards"); g_log_debug = false; } #else