Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDROM: Mode page 0x2A, READ TRACK INFORMATION, and GET CONFIGURATION #237

Merged
merged 6 commits into from
Jun 9, 2023

Conversation

saybur
Copy link
Contributor

@saybur saybur commented Jun 8, 2023

Proposal to include mode page 0x2A support and a minimal implementation of the MMC-1 version of READ TRACK INFORMATION. The goal here is twofold: improve support for drivers expecting to see 0x2A, and work toward suppressing kernel warnings on Linux.

These are lightly tested: the basic commands appear to work under Linux but other operating systems need to be checked. Adding this has not yet eliminated Linux doing a READ(10) on audio data, producing errors. More changes will be needed before this is a candidate for merging.

If this is out of scope or duplicates existing work obviously feel free to close :)

@PetteriAimonen
Copy link
Collaborator

Good timing, I was about to start adding READ TRACK INFORMATION myself :)

In quick reading looks good to me, but I haven't tested on hardware.
Seems low-risk for merge, just let us know when you consider it ready.

@saybur
Copy link
Contributor Author

saybur commented Jun 8, 2023

Will do. I agree these seem pretty safe; the issue I ran out of time to resolve last night was a mismatch between the new command and GET CAPACITY. The new code was matching a real CD, so I have a suspicion that GET CAPACITY may have an off-by-one error similar to what you caught in #236. I wanted to be sure which one was wrong before marking this as ready. Hopefully will get an answer on that later today.

@saybur
Copy link
Contributor Author

saybur commented Jun 9, 2023

The capacity command appears to be fine after testing.

In very happy news adding GET CONFIGURATION support has stopped the kernel errors.

Testing still needs to be done, but that shouldn't be too complicated at this point. I'll change the state of the PR once that's complete.

@saybur saybur changed the title CDROM: Mode page 0x2A and READ TRACK INFORMATION CDROM: Mode page 0x2A, READ TRACK INFORMATION, and GET CONFIGURATION Jun 9, 2023
@saybur saybur marked this pull request as ready for review June 9, 2023 13:05
@aperezbios aperezbios merged commit 3d8dd5d into ZuluSCSI:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants