Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware size check doesn't include the size of the bootloader #227

Closed
morio opened this issue May 26, 2023 · 1 comment
Closed

Firmware size check doesn't include the size of the bootloader #227

morio opened this issue May 26, 2023 · 1 comment

Comments

@morio
Copy link
Collaborator

morio commented May 26, 2023

Should the line below be something like if (fwsize > PLATFORM_FLASH_TOTAL_SIZE - PLATFORM_BOOTLOADER_SIZE) ?

if (fwsize > PLATFORM_FLASH_TOTAL_SIZE)

@PetteriAimonen
Copy link
Collaborator

Yeah, I think it should.

The platformio build process will throw an error if the size is larger than the size specified in linker script. But indeed the bootloader check will not error out if the firmware size is just slightly too large.

aperezbios added a commit that referenced this issue Jun 19, 2023
Fix bootloader size comparison (fix #227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants