Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check List CLI #2

Open
blink1073 opened this issue Aug 20, 2020 · 10 comments
Open

Check List CLI #2

blink1073 opened this issue Aug 20, 2020 · 10 comments

Comments

@blink1073
Copy link

Example:

jupyter server extension list 1>serverextensions 2>&1
cat serverextensions | grep "nbdime.*OK"
@Zsailer
Copy link
Owner

Zsailer commented Aug 21, 2020

All "old" extensions are going to fail this test until they switch from jupyter_notebook_config.d to jupyter_server_config.d.

NBClassic enables the ServerApp to find these extensions, even when their config exists in the old location (jupyter_notebook_config.d), but the jupyter server extension list command won't show these extensions. They only appear with the jupyter serverextension list (no space) entrypoint from the notebook package.

@blink1073
Copy link
Author

Hmm, I think server extension list should show them then with a note.

@Zsailer
Copy link
Owner

Zsailer commented Aug 21, 2020

I think the only way to do this is to add a shim directly in jupyter_server. Ideally, we might hijack this in nbclassic, but I think this would be tricky and (possibly) buggy.

@Zsailer
Copy link
Owner

Zsailer commented Aug 21, 2020

I'll look at this more this afternoon.

@blink1073
Copy link
Author

Hmm, what happens if a package has metadata for both? Do we load it as a new style extension? If so, then that would be a way for folks to bridge the gap.

@Zsailer
Copy link
Owner

Zsailer commented Aug 21, 2020

Hmm, what happens if a package has metadata for both? Do we load it as a new style extension?

That's actually an important question that I haven't verified... The answer should be yes. jupyter_server_config.d should supersede jupyter_notebook_config.d. I'll make sure that's working.

In that case, if the package has metadata for both, both will get installed and jupyter server extension list will show that extension using the config in jupyter_server_config.d. We can make PRs to server extensions to add this config...

@Zsailer
Copy link
Owner

Zsailer commented Aug 21, 2020

jupyter/nbclassic#22 ensures jupyter_server_config supercedes jupyter_notebook_config. Now, an extension could install both, and jupyter_server will only use the jupyter_server_config content.

@Zsailer
Copy link
Owner

Zsailer commented Aug 21, 2020

This doesn't solve the issue here of course. I think this means we need to: 1) submit PRs to all server extensions with the new extension config, 2) add a message to jupyter_server's list command saying this won't list items in jupyter_notebook_config, or 3) add logic in jupyter_server to list these items temporarily...

@blink1073
Copy link
Author

I think server should be able to list them but not have logic to load them, at least during a transitional period.

@blink1073
Copy link
Author

I think it should also warn if it finds them but nbclassic is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants