-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully degrade to blind signing in the known transaction, unknown structure case #39
Comments
Hey @cwgoes! With unknown structure you mean, not having the sections the app is expecting (Code, Data, signature ....) ? |
yeah exactly! @cwgoes |
@murisi Can you help clarify here? I believe this was from our discussion. |
Sure, let me try... I think that Namada transactions can be understood in two layers: the container format and the data formats. The container format describes the structure of the header and the various sections including the code section, data section, and extra data section. The data formats describe how the bytes inside the data section, extra data section, and other sections are interpreted. I.e. the bytes inside a data section may be interpreted as a We would like hardware wallet blind signing to work in the case where the container is valid, but the data is invalid. I.e. if the hardware wallet fails to read the bytes in a data section as a |
When the Ledger app receives a known transaction (by tag) with an unknown structure, we should gracefully degrade (instead of crash), and allow the user to blind-sign, if they want.
The text was updated successfully, but these errors were encountered: