Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q1 Ledger App - New Functionality: Support tokens with decimals different than 8 #248

Open
lmuntaner opened this issue Oct 8, 2024 · 5 comments

Comments

@lmuntaner
Copy link

lmuntaner commented Oct 8, 2024

The display of tokens in a user-friendly way assumes that the token uses 8 decimals. However, there are a number of tokens that use a different number.

We'd like to hard-code the list of tokens that should be displayed in a user-friendly way:

  • If a token isn't in the list, it should be displayed as the raw integer and not formatted.
  • If a token is in the list, use the decimals to display the amount.

List of supported tokens:

tokens.json.txt

🔗 zboto Link

@lmuntaner lmuntaner changed the title Support tokens with decimals different than 8 Ledger App - New Functionality: Support tokens with decimals different than 8 Nov 20, 2024
@lmuntaner
Copy link
Author

UPDATE: An engineer started looking into it.

@neithanmo
Copy link
Collaborator

@lmuntaner does this also apply to Fees?

@sourajyoti-gupta
Copy link

We've added it, but it now breaks many of our tests within the app. We're currently checking the integration feasibility and investigating this further but it is likely that we might need to update the test vectors to be able to support the feature. Is this something Nat discussed with you already @lmuntaner ?

@lmuntaner lmuntaner changed the title Ledger App - New Functionality: Support tokens with decimals different than 8 Q1 Ledger App - New Functionality: Support tokens with decimals different than 8 Dec 18, 2024
@lmuntaner
Copy link
Author

Priority Q1 2025

@sourajyoti-gupta
Copy link

Update (18 Dec):

Completed and soon to be a release separately so it could be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants