New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug: class_embedding is added twice in img_encoder #4

Open

wizyoung opened this issue Mar 28, 2023 · 1 comment

wizyoung commented Mar 28, 2023

In https://github.com/ZiqinZhou66/ZegCLIP/blob/main/models/backbone/img_encoder.py#L231 of img_encoder.py, class_embedding is added twice. Is this a bug?

Owner

ZiqinZhou66 commented Apr 8, 2023

Thanks for your interest in our work. We inherit the same forward function as DenseCLIP https://github.com/raoyongming/DenseCLIP/blob/3b72447dee3f622f3716738140161ef9f763c72f/segmentation/denseclip/models.py#L525. It seems a bug that the original code added the class_embedding twice. However, due to we apply the visual prompt tuning on encoder the final effect might be slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment